-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
done seekHelp midfi #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks mostly good, check the caret thing. Also lmk if u find a way to make the whole button collapsible/expandable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks mainly good
TIME FOR STYLING!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOOKIN GOOD BROTHER
* changed page setup to render supabase data * display is now sorted based on page number * passing in full data for each language to video page * new videos kinda working, just not playing rip; having problems with useState not being instant * lowk finished, but useState making solution a bit scuffed... video's not playing anymore. but all the interactivity with supabase and within the app works lol * not much, only rerendered on index now, comments for better understanding, video still not playing rip * finished sprint, video plays bc of useref instead of usestate * fixed very minor bug where the first page wont display * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <[email protected]> Co-authored-by: philipye314 <[email protected]> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <[email protected]> * [bug fix] removed extra type file * Charlottelaw/jdi 14 tab navigation (#12) * navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <[email protected]> Co-authored-by: philipye314 <[email protected]> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <[email protected]> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <[email protected]> Co-authored-by: CodyGarciaa <[email protected]> Co-authored-by: angelinetu <[email protected]> Co-authored-by: Philip Ye <[email protected]> Co-authored-by: philipye314 <[email protected]> Co-authored-by: Arfa Momin <[email protected]> * fixed some style, tried video player a bit * Charlottelaw/jdi 14 tab navigation (#12) * navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <[email protected]> Co-authored-by: philipye314 <[email protected]> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <[email protected]> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <[email protected]> Co-authored-by: CodyGarciaa <[email protected]> Co-authored-by: angelinetu <[email protected]> Co-authored-by: Philip Ye <[email protected]> Co-authored-by: philipye314 <[email protected]> Co-authored-by: Arfa Momin <[email protected]> * changed page setup to render supabase data * passing in full data for each language to video page * fixed type errors * deleted unnecessary files * fixed philip's comments besides english/spanishModule's defualt usestate * fixed some pretty warnings * done seekHelp midfi (#21) * done seekHelp midfi * moved caret + made button collapsable * styling changes * minor styling changes * minor == fix --------- Co-authored-by: philipye314 <[email protected]> * changed page setup to render supabase data * display is now sorted based on page number * passing in full data for each language to video page * new videos kinda working, just not playing rip; having problems with useState not being instant * lowk finished, but useState making solution a bit scuffed... video's not playing anymore. but all the interactivity with supabase and within the app works lol * not much, only rerendered on index now, comments for better understanding, video still not playing rip * finished sprint, video plays bc of useref instead of usestate * fixed very minor bug where the first page wont display * Charlottelaw/jdi 14 tab navigation (#12) * navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <[email protected]> Co-authored-by: philipye314 <[email protected]> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <[email protected]> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <[email protected]> Co-authored-by: CodyGarciaa <[email protected]> Co-authored-by: angelinetu <[email protected]> Co-authored-by: Philip Ye <[email protected]> Co-authored-by: philipye314 <[email protected]> Co-authored-by: Arfa Momin <[email protected]> * fixed some style, tried video player a bit * Charlottelaw/jdi 14 tab navigation (#12) * navigation * got rid of unused files * CodyGarciaa/Legal-Rights-Prea-Pages (#13) * set up legal rights skeleton, can go to video page with nothing there yet tho * added video and testing player * more testing with video, lowk not getting .mp4 to work * legal rights page scrollable * added caption buttons, lowk still to add more to it * closed caption buttons are toggleable and XOR * finished pr * resolved philip's problems lol * 5 create resources sub pages (#15) * seek help to resource list * seek help to resource list * fixed some things * removed unused import --------- Co-authored-by: Philip Ye <[email protected]> Co-authored-by: philipye314 <[email protected]> * 8-healing-resource-pages (#19) * [feat] resources rendered and scrolling by buttons * good work arfa, minor adjustments --------- Co-authored-by: philipye314 <[email protected]> * [bug fix] removed extra type file * navigation * got rid of unused files * [fix] 🐐🐐🐐 * [fix] did screen props * deleted unused files --------- Co-authored-by: philipye314 <[email protected]> Co-authored-by: CodyGarciaa <[email protected]> Co-authored-by: angelinetu <[email protected]> Co-authored-by: Philip Ye <[email protected]> Co-authored-by: philipye314 <[email protected]> Co-authored-by: Arfa Momin <[email protected]> * changed page setup to render supabase data * passing in full data for each language to video page * fixed type errors * deleted unnecessary files * fixed philip's comments besides english/spanishModule's defualt usestate * fixed some pretty warnings * deleted useless file --------- Co-authored-by: angelinetu <[email protected]> Co-authored-by: Philip Ye <[email protected]> Co-authored-by: philipye314 <[email protected]> Co-authored-by: Arfa Momin <[email protected]> Co-authored-by: philipye314 <[email protected]> Co-authored-by: Charlotte Law <[email protected]>
What's new in this PR
Description
Screenshots
How to review
Next steps
Relevant links
Online sources
Related PRs
CC: @philipye314