Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preferences page, styling, and routing between onboarding #11

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

me-liu
Copy link
Contributor

@me-liu me-liu commented Oct 12, 2024

🍞 What's new in this PR

🥐 Description

  • changed the global styling to remove default margins/whitespace. This may mean previously styled pages must be changed
  • preferences page styling
  • navigation between the preferences and onboarding page

🥖 Screenshots

Screenshot 2024-10-12 at 4 46 36 PM

🥪 How to review

  • All at once: the styling is almost exactly the same as my previous PR

🥧 Next steps

  • I will add more global colors soon

🥞 Relevant links

🥨 Online sources

🥯 Related PRs

CC: @celinechoiii

@celinechoiii
Copy link
Collaborator

celinechoiii commented Oct 13, 2024

since all of the styled components from preferences screen overlap with the general screen, can you have a single styles.ts file that can be used across all of the onboarding flow to reduce redundancy? also, could you rearrange the files like the following: onboarding folder --> general folder (contains page.tsx) + preferences folder (contains page.tsx) + styles.ts. if there are any screen specific styled components you would like to add, feel free to add a styled.ts file for that respective folder

app/preferences/styles.ts Outdated Show resolved Hide resolved
app/preferences/styles.ts Outdated Show resolved Hide resolved
app/preferences/styles.ts Outdated Show resolved Hide resolved
app/preferences/page.tsx Outdated Show resolved Hide resolved
font-size: 28px;
text-align: start;
color: ${COLORS.gray11};
margin-top: 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete margin-top and add margin-bottom: 2.25rem; to add more space between title and the first input field

Copy link
Contributor Author

@me-liu me-liu Oct 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I did margin-top: 0 because the title text has some default margins on the top and bottom. I think if do this I end up with a lot of spacing btween the title and the rest of the stuff:
Screenshot 2024-10-19 at 5 35 28 PM

app/preferences/styles.ts Outdated Show resolved Hide resolved
@celinechoiii
Copy link
Collaborator

can you make sure to pull from main? i merged in justin's font pr and now the styling might need some adjustments

app/onboarding/general/page.tsx Outdated Show resolved Hide resolved
app/onboarding/styles.ts Outdated Show resolved Hide resolved
app/onboarding/styles.ts Show resolved Hide resolved
app/onboarding/styles.ts Outdated Show resolved Hide resolved
@celinechoiii celinechoiii merged commit b70429a into main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants