Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/cashier-mini お釣りに負の数を表示させない #408

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Conversation

Astalum
Copy link
Collaborator

@Astalum Astalum commented Nov 2, 2024

close: #392

Copy link
Member

@toririm toririm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この実装はuseMemoを使ったほうが綺麗に書けるかも・・・
ちょっと待ってね

Copy link
Contributor

github-actions bot commented Nov 2, 2024

Visit the preview URL for this PR (updated for commit 3b59718):

https://cafeore-2024--pr408-issue-392-0vje3v8g.web.app

(expires Sat, 09 Nov 2024 20:54:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b62dcde668e26b6280dd8317f3f875013f6f22f5

Copy link
Member

@toririm toririm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作を確認してみて良さそうだったら merge してみてください

@Astalum
Copy link
Collaborator Author

Astalum commented Nov 2, 2024

LGTM

@Astalum Astalum merged commit d6a8676 into main Nov 2, 2024
15 checks passed
@Astalum Astalum deleted the issue/392 branch November 2, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/cashier-mini お釣りに負の数を表示させない
2 participants