issue-28 #255
Merged
issue-28 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 62d4388): https://cafeore-2024--pr255-issue-28-rjovmx02.web.app (expires Mon, 28 Oct 2024 18:11:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b62dcde668e26b6280dd8317f3f875013f6f22f5 |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
スペースだ改行だを修正したら？とのことだったのでLGTMでcommitしました |
toririm
reviewed
Oct 8, 2024
toririm
requested changes
Oct 8, 2024
toririm
reviewed
Oct 8, 2024
これ、もしかしたら早期リターンをやめて、三項演算子で要素の構造を壊さずにOutletの出し入れをしたら修正できるかも。余力あったらやってみてほしい |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #28
オフライン（!isOnline==true）だとOutletが表示されないようにした
もし、if文をreturnの中に入れたかったら入れてもOK