This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
Run app on heroku #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adborden
commented
Mar 22, 2017
adborden
commented
- Configuration for postgres
- Use whitenoise for static files
- Specify python 3.6.0
- Run gunicorn for wsgi
- Configuration for postgres - Use whitenoise for static files - Specify python 3.6.0 - Run gunicorn for wsgi
Should be at the top level. Add it to gitignore.
|
Fixed the conflicts. I also setup CD, so it would be nice if #7 was merged into this first. |
mosdevly
reviewed
Apr 26, 2017
|
|
||
| DATABASES['default'] = dj_database_url.config() | ||
|
|
||
| SECRET_KEY = os.environ.get('SECRET_KEY', None) |
There was a problem hiding this comment.
I made some comments on this in the first PR that basically boil down to this: it must be set. The app won't start. So we don't really need to throw an exception because the app will throw one for us.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.