-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DarkMode and Theme support #68 #78 #114
Conversation
Great start! I think we should store RGBA colors for the status page themes, it's more versatile. I'm on my phone at the moment, but will check this out for a full review soon! |
Note, assets don't need to be committed manually anymore. |
Compile Assets commit is coming from GitHub actions not from me. |
I have changed the PR to RGBA and added font setting |
Ah, thanks! I've made the assets only compile on |
99b50dc
to
51971ff
Compare
# Conflicts: # public/build/manifest.json
@jbrooksuk fixed merge conflicts with main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we need to switch to using a customizable color palette so that we use danger
etc?
You mean, dark, light, system and custom and with custom you get the custom colors? |
@steffjenl I wonder whether we could simplify this to use Filament's own |
You mean the colors setting in Filament? and add those six colors ?
|
@steffjenl yeah, maybe? But, these colors should be passed to Cachet's frontend. If we use Filament's |
@steffjenl I think we should simplify the color schemes even more. Why don't we take inspiration from @calebporzio with Flux? https://fluxui.dev/themes We could still allow you to change status colors, but we ask for an accent color and generate the grays from it? Anything really custom could be done with CSS. |
I've replaced this PR with #143. The only thing we could add is the theme switcher. |
Edit screen:
Statuspage:
I think we must add more colors to change