Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DarkMode and Theme support #68 #78 #114

Closed
wants to merge 17 commits into from

Conversation

steffjenl
Copy link
Contributor

Edit screen:
image

Statuspage:
image

I think we must add more colors to change

@jbrooksuk
Copy link
Member

Great start! I think we should store RGBA colors for the status page themes, it's more versatile.

I'm on my phone at the moment, but will check this out for a full review soon!

@jbrooksuk
Copy link
Member

Note, assets don't need to be committed manually anymore.

@steffjenl
Copy link
Contributor Author

Note, assets don't need to be committed manually anymore.

Compile Assets commit is coming from GitHub actions not from me.

@steffjenl
Copy link
Contributor Author

Great start! I think we should store RGBA colors for the status page themes, it's more versatile.

I'm on my phone at the moment, but will check this out for a full review soon!

I have changed the PR to RGBA and added font setting

@steffjenl
Copy link
Contributor Author

image

image

@jbrooksuk
Copy link
Member

Ah, thanks! I've made the assets only compile on main now.

@jbrooksuk jbrooksuk force-pushed the feature/issue-78-and-68 branch from 99b50dc to 51971ff Compare October 14, 2024 11:28
@steffjenl
Copy link
Contributor Author

@jbrooksuk fixed merge conflicts with main

Copy link
Member

@jbrooksuk jbrooksuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need to switch to using a customizable color palette so that we use danger etc?

resources/views/components/cachet.blade.php Outdated Show resolved Hide resolved
@steffjenl
Copy link
Contributor Author

resources/views/components/cachet.blade.php

You mean, dark, light, system and custom and with custom you get the custom colors?

@steffjenl steffjenl requested a review from jbrooksuk October 25, 2024 20:04
@jbrooksuk
Copy link
Member

@steffjenl I wonder whether we could simplify this to use Filament's own Color class? We just store the primary color and then generate the shades for that? We'd need to change the Tailwind config to read from the CSS variables instead though. Maybe that's a lot of work?

@steffjenl
Copy link
Contributor Author

@steffjenl I wonder whether we could simplify this to use Filament's own Color class? We just store the primary color and then generate the shades for that? We'd need to change the Tailwind config to read from the CSS variables instead though. Maybe that's a lot of work?

You mean the colors setting in Filament? and add those six colors ?

return $panel // ... ->colors([ 'danger' => Color::Rose, 'gray' => Color::Gray, 'info' => Color::Blue, 'primary' => Color::Indigo, 'success' => Color::Emerald, 'warning' => Color::Orange, ]);

@jbrooksuk
Copy link
Member

@steffjenl yeah, maybe? But, these colors should be passed to Cachet's frontend. If we use Filament's Color class, we can get access to the CSS variables and use them directly in Cachet.

@jbrooksuk
Copy link
Member

@steffjenl I think we should simplify the color schemes even more. Why don't we take inspiration from @calebporzio with Flux? https://fluxui.dev/themes

We could still allow you to change status colors, but we ask for an accent color and generate the grays from it? Anything really custom could be done with CSS.

@jbrooksuk jbrooksuk mentioned this pull request Dec 18, 2024
@jbrooksuk
Copy link
Member

jbrooksuk commented Dec 18, 2024

I've replaced this PR with #143.

The only thing we could add is the theme switcher.

@jbrooksuk jbrooksuk closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants