feedback + tidy up

cachethq · Oct 18, 2024 · 44bb282 · 44bb282
1 parent 0305ec8
commit 44bb282
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/Commands/InstallCommand.php b/src/Commands/InstallCommand.php
@@ -9,7 +9,6 @@
 use Illuminate\Support\Facades\File;
 use Illuminate\Support\Sleep;
 use Illuminate\Support\Str;
-use Laravel\Prompts\Prompt;
 use ReflectionClass;
 use ReflectionProperty;
 use function Laravel\Prompts\confirm;
@@ -24,7 +23,7 @@ class InstallCommand extends Command
 
     protected $description = 'Install Cachet';
 
-    public function handle(AppSettings $settings)
+    public function handle(AppSettings $settings): int
     {
         intro('Welcome to the Cachet installer!');
 
@@ -123,8 +122,8 @@ protected function configureDatabaseSettings(AppSettings $settings): AppSettings
                 }
 
                 $descriptionAttributeClass = $descriptionAttribute[0]->newInstance();
-                $default = $descriptionAttributeClass->getDefault();
-                $required = $descriptionAttributeClass->getRequired();
+                $default = $descriptionAttributeClass->default();
+                $required = $descriptionAttributeClass->required();
 
                 if ($required === false) {
                     return;

diff --git a/src/Settings/Attributes/Description.php b/src/Settings/Attributes/Description.php
@@ -9,12 +9,12 @@ final class Description
 {
     public function __construct(private readonly string $default, private readonly bool $required = true) {}
 
-    public function getDefault(): string
+    public function default(): string
     {
         return $this->default;
     }
 
-    public function getRequired(): bool
+    public function required(): bool
     {
         return $this->required;
     }