feat: added new workflow to prune old images #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JTaeuber
requested review from
y-eight,
niklastreml,
puffitos,
lvlcn-t and
eumel8
as code owners
JTaeuber
added
feature
puffitos
requested changes
Jan 25, 2024
y-eight
reviewed
Jan 26, 2024
lvlcn-t
reviewed
Jan 26, 2024
| prune-untagged: true | ||
| prune-tags-regexes: | | ||
| ^commit- | ||
| SNAPSHOT-.*$ |
There was a problem hiding this comment.
After the first prune we can remove this regex because our new images don't follow this naming pattern anymore.
There was a problem hiding this comment.
The regex is unnecessary. We just want to remove old images, no matter what naming convention they used. Let's just remove it altogether.
There was a problem hiding this comment.
Then we'd also remove our stable release images because git tags != image tags
puffitos
approved these changes
Jan 29, 2024
lvlcn-t
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
LGTM, don't forget to turn off the dryrun before merging.
Additionally after merging create a PR to resolve my conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Relates to #80
Changes
Added a new workflow to prune old images of packages sparrow and charts/sparrow.
The workflow is configured to prune all images older than 7 days that start with 'commit-' or end in 'SNAPSHOT-...' for the sparrow package.
For the charts/sparrow package it will prune all images older than 7 days that end in 'commit-...'.
It runs daily at midnight (could be changed if wanted).
It is still configured to dry-run just to be sure. This should be changed once we're sure nothings going to break.
For additional information look at the commits.
Tests done
I've tested the workflow in dry-run in a fork I made and it worked accordingly.
No stable version or version under 7 days was marked for pruning.
https://github.com/JTaeuber/sparrow/actions/runs/7642146860
This is the Test of the Workflow without keeping the images younger than 7 days for the charts/sparrow package, so you can see what it would prune if they were older than 7 days.
TODO