Added missing job resource on clusterrole #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricjsan
requested review from
Fovty,
jonathan-mayer,
JTaeuber and
samuel-esp
as code owners
|
Hi @ricjsan thanks a lot for your contribution to the project. If I'm not mistaking I I addressed this issue mid-August in the release 24.8.2. I did a quick check and seems to present in the code. Are you facing problems with that release version? |
|
Hey @samuel-esp, I took a quick look again and you are both right. |
JTaeuber
approved these changes
Sep 25, 2024
|
Perfect, @JTaeuber, thank you very much! |
samuel-esp
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This update fixes 403 that error that occurs if you deploy KD with the helm chart and include job resources.
This error occurred because the service account did not had permission to manage job resources.
Changes
On ClusterRole at the helm template rbac.yaml added the jobs resource next to cronjobs.
Tests done
None