[helm chart] replace name with fullname helper #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekcah78
requested review from
Fovty,
jonathan-mayer and
JTaeuber
as code owners
rekcah78
force-pushed
the
fix-fullnameoverride
branch
from
2c1b500
to
e694672
Compare
JTaeuber
changed the title
JTaeuber
requested changes
Aug 12, 2024
|
Other than that these changes are good. If you made the changes and rebased the branch so it includes the changes of #78 we can merge this. |
|
Okay perfect, now we just need a rebase to resolve the current merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Value fullnameOverride can't be used
Changes
Helm Chart
Tests done
TODO