FEATURE: [xalign] add notification when order quote is over alert amount #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back! @kbearXD, This pull request may get 225 BBG. |
c9s
reviewed
Oct 28, 2024
c9s
reviewed
Oct 28, 2024
kbearXD
force-pushed
the
kbearXD/xalign/notify-if-large-amount
branch
from
52ec12a
to
302b78f
Compare
|
Re-estimated karma: this pull request may get 270 BBG |
kbearXD
force-pushed
the
kbearXD/xalign/notify-if-large-amount
branch
from
302b78f
to
1813f4c
Compare
|
Re-estimated karma: this pull request may get 361 BBG |
kbearXD
force-pushed
the
kbearXD/xalign/notify-if-large-amount
branch
from
1813f4c
to
57e42ad
Compare
|
Re-estimated karma: this pull request may get 348 BBG |
kbearXD
force-pushed
the
kbearXD/xalign/notify-if-large-amount
branch
from
57e42ad
to
caf5d69
Compare
|
Re-estimated karma: this pull request may get 360 BBG |
c9s
reviewed
Nov 5, 2024
pkg/strategy/xalign/strategy.go
Outdated
| @@ -50,6 +100,7 @@ type Strategy struct { | |||
| BalanceToleranceRange fixedpoint.Value `json:"balanceToleranceRange"` | |||
| Duration types.Duration `json:"for"` | |||
| MaxAmounts map[string]fixedpoint.Value `json:"maxAmounts"` | |||
| MaxAmountAlert *MaxAmountAlertConfig `json:"maxAmountAlert"` | |||
| func (m *MaxAmountAlert) SlackAttachment() slack.Attachment { | ||
| return slack.Attachment{ | ||
| Color: "red", | ||
| Title: fmt.Sprintf("xalign amount alert - try to align %s with quote %s amount %f > %f", |
| @@ -50,6 +100,7 @@ type Strategy struct { | |||
| BalanceToleranceRange fixedpoint.Value `json:"balanceToleranceRange"` | |||
| Duration types.Duration `json:"for"` | |||
| MaxAmounts map[string]fixedpoint.Value `json:"maxAmounts"` | |||
c9s
approved these changes
Nov 11, 2024
kbearXD
force-pushed
the
kbearXD/xalign/notify-if-large-amount
branch
from
caf5d69
to
b47fc08
Compare
|
Re-estimated karma: this pull request may get 395 BBG |
|
Hi @kbearXD, Well done! 400 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x00a1d9d4c03a333acfcecaa395175f8b61d2a70ba91da4536cf262c848ef088a Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.