Add more sistalk monsterpub devices and sensors for them

[anon1im]

Added a few devices that I own and could reverse engineer

Tested with intiface-engine and a python script.

I wanted to add subscriptions to newly added sensors, but couldn't find any mention of SensorSubscribeCmd in buttplug-device-config-v3.yml

[CLAassistant]

All committers have signed the CLA.

[blackspherefollower]

Exactly which devices did you test? The config updates suggest pressure sensors on devices I'm fairly certain do not have them.

[anon1im]

There is "Monster Pub 2 Premium Version" lineup, also called "Monster Pub Kegel" (here).

I have tested:

• Monster Pub 2 Dr. Whale Premium,
• Monster Pub Flex (for some reason called "BeatHeart" in the device config and "Mr.Devil 1N" in manufacturer's app
• Monster Pub 2 Master Godkilla

Dr. Whale Premium's pressure sensor works in official app and when using buttplug api

[blackspherefollower]

So, I think there's a bit of a translation issue somewhere: the MonsterPub devices (with a few exceptions) come in Whale, Devil and "Godzilla" not Godkilla.

The existing Whale 2 identifier was another model with pressure sensor. The new identifier should just be added to the existing configuration.

[blackspherefollower]

I suspect that the new identifier should have been noted on buttplugio/docs.buttplug.io#19 first

[anon1im]

Naming is a mess: Godzilla is named as "Gokilla" and "Godkilla" on the same screen in the Monster Pub App.

Ok, I'll comment new info in the issue

[anon1im]

Renamed Godkilla to Godzilla and merged "premium" Whale 2 with existing one.

[blackspherefollower]

I think this is a good start.
When I get back, I'll see if the battery readings can be more generalized across the entire brand.

I think longer term, pressure levels via subscription will be more useful, but I'm waiting for the next iteration of the sensor support in the Buttplug protocol before I was going to start looking into that seriously.