Brianna/step-one #15
Brianna/step-one #15
Conversation
BCerki
force-pushed
the
brianna/step-one
branch
from
96475ba to
dac185d
Compare
BCerki
force-pushed
the
brianna/step-one
branch
from
dac185d to
62e0df9
Compare
| task text not null, | ||
| completed boolean not null default false, | ||
| date_created timestamptz not null default now(), | ||
| date_updated timestamptz not null default now() |
There was a problem hiding this comment.
I originally forgot to include default now() and to get it in, I had to revert and then redeploy. Is that the right way to do it?
There was a problem hiding this comment.
In your development environment, yes. For some changes the way might even be to drop and recreate your db.
If this happens in a prod environment, you will have to create a new change which alters the column. The changes that are already deployed should be immutable. You can't revert and redeploy there otherwise you're dropping the tables and loosing your data
| task text not null, | ||
| completed boolean not null default false, | ||
| date_created timestamptz not null default now(), | ||
| date_updated timestamptz not null default now() |
There was a problem hiding this comment.
In your development environment, yes. For some changes the way might even be to drop and recreate your db.
If this happens in a prod environment, you will have to create a new change which alters the column. The changes that are already deployed should be immutable. You can't revert and redeploy there otherwise you're dropping the tables and loosing your data
| %syntax-version=1.0.0 | ||
| %project=todo_app | ||
|
|
||
| todo_appschema 2022-02-23T22:43:21Z Brianna Cerkiewicz <briannacerkiewicz@pop-os> # Add schema for all todo objects. |
There was a problem hiding this comment.
remember to configure sqitch to have your work email in your profile
| create or replace function todo_app.insert_todo( | ||
| task text, | ||
| completed boolean | ||
| ) returns void language sql security definer as $$ |
There was a problem hiding this comment.
defining a function with security definer is to be avoided if possible. A security definer function will be executed with the privileges of the user that creates it.
|
|
||
| BEGIN; | ||
|
|
||
| create or replace function todo_app.insert_todo( |
There was a problem hiding this comment.
In most cases you won't need to create functions to insert your data. postgraphile will automatically generate graphql mutations to insert, update and delete data.
| BEGIN; | ||
|
|
||
| select todo_app.insert_todo('task not done', false); | ||
| select todo_app.insert_todo('task done', true); | ||
|
|
||
| COMMIT; |
There was a problem hiding this comment.
for seed data, we've been following the following pattern in our project:
- if the data is actually "seed" data, i.e. the initial data which can later be modified by our users, then a sqitch migration, like this is good
- if the data is hardcoded data, which users are not expected to change, but developers may want to change between releases, we use a different set of sql scripts containing idempotent changes (example from the ciip repo).
No description provided.