Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated for running koans with Dart2 #9

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

ericomine
Copy link

From what I could see, these koans are the most referenced Dart koans online, but they were not updated to work with Dart2.

  • Replaced dart-sdk requirement to ^2.3.0
  • Replaced legacy unittest dep with test.
  • Most change in code due to change in testing API (isInstanceOf has been deprecated, using isA instead)

@butlermatt
Copy link
Owner

Hey thanks. I wasn't even aware this project was looked at in years.
Unfortunately I have a few different matters going on at just the moment, and it may take me a few days to go through this PR, but I did want to leave a note to let you know I've seen your PR and will hopefully be able to give a more thorough review in a few days. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants