Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Commit

Permalink
Fix PR template and add info to changelog script (#237)
Browse files Browse the repository at this point in the history
  • Loading branch information
alysivji authored Apr 9, 2020
1 parent 373f8f5 commit f8a7ae9
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 8 deletions.
18 changes: 12 additions & 6 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,20 @@
Closes #

[Context]
Closes # (if there is a related issue)

### What does this do

[high-level description of features]
[high-level description of what this PR does]

### Why are we doing this

[description of why]

### How should this be tested

[what tests have been written, any tests to perform after merging and deploying?]

### Callouts
### Migrations

[anything you want to call out]
[post SQL here]

### Dependencies

Expand Down
12 changes: 10 additions & 2 deletions scripts/generate_changelog.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,16 @@
def generate_changelog(owner, repo, version):
github = GitHubClient()
release_dt = github.get_release_date(owner, repo, version)
return github.get_commit_messages(owner, repo, release_dt)
messages = github.get_commit_messages(owner, repo, release_dt)

# generate changelog
if not messages:
return []

output = ["### Changes", ""]
for message in messages:
output.append("- " + message)
return output


class GitHubClient:
Expand Down Expand Up @@ -63,5 +72,4 @@ def parse_args():
repo = "busy-beaver"

changelog = generate_changelog(owner, repo, version)
print()
print("\n".join(changelog))

0 comments on commit f8a7ae9

Please sign in to comment.