Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robust model limits #247

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Robust model limits #247

wants to merge 3 commits into from

Conversation

jmerdich
Copy link

General changes to better respect settings.REPORT_BUILDER_IN/EXCLUDE:

  • Checks if models actually exist (or are ambiguous) and raises ImproperlyConfigured
  • Ignore case. ContentTypes are always lowercase anyways
  • Handle full paths, a la "django.contrib.auth.user"
  • Don't show models we can't use in the add view

@jmerdich
Copy link
Author

Failing tests are identical to the ones in master...

@bufke
Copy link
Member

bufke commented Nov 30, 2016

Try rebasing it - tests should now pass

@jmerdich
Make IN/EXCLUDE setting more robust
38e3e72 
Includes:
 - Checking existance and ambiguity of models (raising ImproperlyConfigured)
 - A nice, loud error message for invalid models
 - Allows long-format names ('django.contrib.auth.user')
 - Model names are case-insensitive ('auth.User')
@jmerdich
Don't show invalid roots for add view
298104b
@jmerdich
pep8
ef08a35
@jmerdich jmerdich force-pushed the robust_model_limits branch from bbc5605 to ef08a35 Compare November 30, 2016 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmerdich @bufke