Ensure the downloaded os/arch always matches the expected os/arch #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/enhancement
natalieparellano
changed the title
- the builder for `pack build` - the previous image for `pack rebase` Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
force-pushed
the
fix/run-image-multi-arch
branch
from
c2605e5 to
5728158
Compare
…uilder create`, ensure the os/arch matches the builder Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
changed the title
|
I updated this PR a bit to encompass more things. It might be easier to review as two separate commits |
jkutner
approved these changes
Oct 30, 2023
Signed-off-by: Joe Kutner <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, we didn't provide a platform, so if the downloaded thing (run image or buildpack/extension) is multi-arch we would get whatever is the default.
Now, we ensure:
pack buildand previous image forpack rebasepack buildandpack builder create