add pack extension --help #1601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/enhancement
itsdarshankumar
force-pushed
the
pack_extension
branch
4 times, most recently
from
4019128 to
5985da8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
- Coverage 80.58% 78.87% -1.71%
==========================================
Files 156 163 +7
Lines 10480 10578 +98
==========================================
- Hits 8444 8342 -102
- Misses 1534 1734 +200
Partials 502 502
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Darshan Kumar <[email protected]>
Signed-off-by: Joe Kimmel <[email protected]>
itsdarshankumar
force-pushed
the
pack_extension
branch
from
5985da8 to
58b1a02
Compare
Signed-off-by: Joe Kimmel <[email protected]> Signed-off-by: Darshan Kumar <[email protected]>
itsdarshankumar
force-pushed
the
pack_extension
branch
from
58b1a02 to
45f6c67
Compare
jjbustamante
requested changes
Jan 20, 2023
There was a problem hiding this comment.
Great job @itsdarshankumar.
A part from my doubt with the location of NewExtensionCommand and the fact that I think the PR needs to rebase against the main branch. Every thing looks good to me!
| @@ -76,6 +76,7 @@ func NewPackCommand(logger ConfigurableLogger) (*cobra.Command, error) { | |||
| rootCmd.AddCommand(commands.Build(logger, cfg, packClient)) | |||
| rootCmd.AddCommand(commands.NewBuilderCommand(logger, cfg, packClient)) | |||
| rootCmd.AddCommand(commands.NewBuildpackCommand(logger, cfg, packClient, buildpackage.NewConfigReader())) | |||
| rootCmd.AddCommand(commands.NewExtensionCommand(logger, cfg, packClient, buildpackage.NewConfigReader())) | |||
There was a problem hiding this comment.
I wonder if this line should be move inside the statement if cfg.Experimental on line 100. I believe the extensions is actually an experimental feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added command to show output for "pack extension --help"
Output
Before
No such command exists before
Related
Resolves #1470