-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide buildpack create
command
#1534
base: main
Are you sure you want to change the base?
Conversation
6db2fc5
to
8615afe
Compare
Depends on buildpacks-community/scafall#2 will undraft when that (and some subsequent changes) land. |
8615afe
to
6e320e4
Compare
6e320e4
to
99421fe
Compare
This draft can be driven using
We don't yet have a https://github.com/buildpacks/templates repo that contains a template (awaiting buildpacks/templates#1). A bare |
99421fe
to
c36879a
Compare
c36879a
to
c4b2f8f
Compare
c4b2f8f
to
47b1a59
Compare
7445046
to
150c2ae
Compare
150c2ae
to
6481444
Compare
@AidanDelaney what's the status of this one? |
@AidanDelaney I think we are good with this one, right? the dependencies:
Can you rebase to the latest? there is a problem with the Windows Acceptance Test (LCOW) but I am trying to solve that |
6481444
to
c7d4a14
Compare
go.mod
Outdated
github.com/docker/cli v24.0.6+incompatible | ||
github.com/docker/docker v24.0.7+incompatible | ||
github.com/docker/go-connections v0.4.0 | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here you are using older versions for
github.com/docker/cli v24.0.7+incompatible
github.com/docker/go-connections v0.5.0
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1534 +/- ##
==========================================
+ Coverage 78.96% 79.53% +0.57%
==========================================
Files 176 178 +2
Lines 13246 13314 +68
==========================================
+ Hits 10459 10588 +129
+ Misses 2119 2053 -66
- Partials 668 673 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
e757d06
to
e5b5b68
Compare
Implement RFC 212 to provide a more general mechanism to provide project scaffolding for new buildpacks. Signed-off-by: Aidan Delaney <[email protected]>
e5b5b68
to
c61741a
Compare
Any further updates here? |
Oh! I thought this was merged months ago. Sorry. Let's have a quick chat about this in our weekly catchup. |
Implement RFC 212 to provide a more general mechanism to provide project scaffolding for new buildpacks.
Summary
Uses https://github.com/AidanDelaney/scafall to implement RFC 212.
Defaults to
bash
subpath of https://github.com/AidanDelaney/cnb-buildpack-templates to provide the default template.Open Questions
scafall
to the buildpacks org?cnb-buildpack-templates
to the buildpacks org (and maybe rename tocnb-templates
)?Documentation
Related
Resolves #___