Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version reference from 1.23 to 1.23.0 #1435

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kfri-lmco
Copy link

Update go version reference from 1.23 to 1.23.0

Summary

Updates go version reference in go.mod to 1.23.0. The current go reference is invalid (1.23) causing an error when attempting to build the lifecycle component.

Documentation instructs users to make the lifecycle package (eg: make build-darwin-amd64). This instruction fails when attempting to download the referenced version of go with a message like:

go: downloading go1.23 (darwin/amd64)
go: download go1.23 for darwin/amd64: toolchain not available
make: *** [build-darwin-amd64-lifecycle] Error 1

Release notes

Fixes make errors based on invalid go version reference in go.mod file. Updates go version reference to 1.23.0.


Update go version reference from 1.23 to 1.23.0

Signed-off-by: kfri-lmco <[email protected]>
fix: update go version in mod file
@kfri-lmco kfri-lmco requested a review from a team as a code owner December 4, 2024 16:35
@jabrown85
Copy link
Contributor

jabrown85 commented Dec 4, 2024

@kfri-lmco - what version of go were you using to get that error? I'm not overly familiar with the new toolchain stuff but my test worked as is using golang:1.22.10-alpine as my base go version that didn't already match the minor version.

/workspace # go build ./...
go: go.mod requires go >= 1.23 (running go 1.22.10; GOTOOLCHAIN=local)

/workspace # GOTOOLCHAIN=auto go build ./...
go: downloading go1.23.0 (linux/arm64)
go: downloading github.com/buildpacks/imgutil v0.0.0-20240605145725-186f89b2d168
...

@gogolok
Copy link
Contributor

gogolok commented Dec 4, 2024

That's strange. go 1.23 is valid according to https://go.dev/doc/modules/gomod-ref#go . I would also be interested in the version trying that update.

On the other hand, there is some interesting discussion in golang/go#62278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants