Use the the latest version of containerd 1.6.x instead of 1.7.x #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <[email protected]>
jabrown85
reviewed
Oct 3, 2023
| // Ensure we only pull in the latest version of containerd | ||
| replace github.com/containerd/containerd => github.com/containerd/containerd v1.7.6 | ||
| // Ensure we only pull in the latest version of containerd 1.6.x | ||
| replace github.com/containerd/containerd => github.com/containerd/containerd v1.6.24 |
There was a problem hiding this comment.
Can we remove this in favor of github.com/containerd/containerd v1.6.24 in the main require block? Or what does that end up downgrading?
There was a problem hiding this comment.
I tried that but go mod tidy always bumps it back up to v1.7.6
There was a problem hiding this comment.
I wonder if this fixes the issue then - I don't think go tool respects the replace directives when importing as a library.
There was a problem hiding this comment.
Ohhh... you are right 🤔
There was a problem hiding this comment.
It looks like kaniko is probably one of the main packages forcing our hand here to a later containerd version. Oh well I suppose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have tried to be on the latest version of containerd as it has been a source of CVEs in the past. However the 1.7.x line is incompatible with older versions of k8s. This change would allow library consumers to upgrade the lifecycle without having to simultaneously upgrade their clusters.
Release notes
Uses the highest version of
github.com/containerd/containerdv1.6.x to facilitate importing the lifecycle as a library in k8s