Add support for darwin-arm64 chipset #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Domenico Luciani <[email protected]>
|
I'm also good with this but I wonder if we could use this as an opportunity to improve our Makefile. It has tons of duplication and is close to 400 lines long at this point :/ ...perhaps we could add some helper scripts to make things more concise? |
… more generic use Signed-off-by: Domenico Luciani <[email protected]>
|
It sounds good to me.
In the future we can do the same for the other actions but I preferred to stay in the scope of this PR. |
Signed-off-by: Domenico Luciani <[email protected]>
|
Thank you for you comments @natalieparellano |
Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Domenico Luciani <[email protected]>
Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Domenico Luciani <[email protected]>
Signed-off-by: Domenico Luciani <[email protected]>
natalieparellano
approved these changes
Aug 10, 2023
|
Is there anything I have to do in order to have this PR merged? @natalieparellano :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add build make actions to build lifecycle for MacOS M1 chipset