Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove katacoda plumbing #644

Merged
merged 3 commits into from
Dec 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -170,22 +170,8 @@ tools-tidy:
cd tools; go mod tidy

.PHONY: prepare-for-pr
prepare-for-pr: check-links test tools-tidy katacoda
prepare-for-pr: check-links test tools-tidy
@echo "========"
@echo "It looks good! :)"
@echo "Make sure to commit all changes!"
@echo "========"

.PHONY: katacoda
katacoda:
@echo "========"
@echo "Generating Katacoda docs..."
@go run katacoda/main.go
@echo "All done!"
@echo "========"

.PHONY: check-katacoda
check-katacoda: katacoda
@echo "Checking if Katacoda docs are up-to-date..."
@git diff --quiet HEAD -- katacoda/scenarios || ( echo "Katacoda docs are not up-to-date! Please run 'make katacoda' and commit the katacoda/scenarios folder" && exit 1)
@echo "All katacoda docs are up-to-date"
2 changes: 0 additions & 2 deletions content/docs/app-developer-guide/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ include_summaries=true
expand=true
+++

{{< katacoda-button href="https://katacoda.com/buildpacks/scenarios/app-developer-guide" color="green" >}} Learn on Katacoda {{</>}}

## Prerequisites

A lot of the examples used within this guide will require the following:
Expand Down
6 changes: 0 additions & 6 deletions content/docs/app-developer-guide/build-an-app.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,6 @@ docker run --rm -p 8080:8080 sample-app
The app should now be running and accessible via [localhost:8080](http://localhost:8080).
<!--+end+-->

<!--+ `
Now open your favorite browser and point it to port "8080" of your host and take a minute to enjoy the view.
On Katacoda you can do this by [clicking here](https://[[HOST_SUBDOMAIN]]-8080-[[KATACODA_HOST]].environments.katacoda.com)
` +-->

## What about ARM apps?

Linux ARM image builds are now supported!
Expand Down
12 changes: 1 addition & 11 deletions content/docs/app-journey.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,13 @@ getting-started=true
## Pack for the journey

In this tutorial, we'll explain how to use `pack` and **buildpacks** to create a runnable app image from source code.
<!--+if false+-->
{{< katacoda-button href="https://katacoda.com/buildpacks/scenarios/app-journey" color="green" >}} Learn on Katacoda {{</>}}

In order to run the build process in an isolated fashion, `pack` uses **Docker**. That means you'll need to make sure you have both `docker` and `pack` installed:

{{< download-button href="https://store.docker.com/search?type=edition&offering=community" color="blue" >}} Install Docker {{</>}}

{{< download-button href="/docs/install-pack" color="pink" >}} Install pack {{</>}}
<!--+end+-->

> **NOTE:** `pack` is only one implementation of the [Cloud Native Buildpacks Platform Specification][cnb-platform-spec]. Additionally, not all Cloud Native Buildpacks Platforms require Docker.
[cnb-platform-spec]: https://github.com/buildpacks/spec/blob/main/platform.md
Expand Down Expand Up @@ -86,14 +84,8 @@ To test out your new app image locally, you can run it with Docker:
docker run --rm -p 8080:8080 myapp
```
<!--+- "{{execute}}"+-->
<!--+- if false+-->
Now hit [`localhost:8080`](http://localhost:8080) in your favorite browser and take a minute to enjoy the view.
<!--+- end+-->
<!--+ `
Now open your favorite browser and point it to port "8080" of your host and take a minute to enjoy the view.

On Katacoda you can do this by [clicking here](https://[[HOST_SUBDOMAIN]]-8080-[[KATACODA_HOST]].environments.katacoda.com)
` +-->

### Take your image to the skies

Expand All @@ -107,9 +99,7 @@ deploying your new image to your favorite cloud!

Windows image builds are now supported!

<!--+- if false+-->
<a href="/docs/app-developer-guide/build-a-windows-app" class="button bg-blue">Windows build guide</a>
<!--+end+-->

[builder]: /docs/concepts/components/builder/
[buildpack]: /docs/concepts/components/buildpack/
Expand Down
1 change: 0 additions & 1 deletion katacoda.yaml

This file was deleted.

17 changes: 0 additions & 17 deletions katacoda/files.txt

This file was deleted.

169 changes: 0 additions & 169 deletions katacoda/main.go

This file was deleted.

6 changes: 0 additions & 6 deletions katacoda/scenarios/app-developer-guide/background.sh

This file was deleted.

71 changes: 0 additions & 71 deletions katacoda/scenarios/app-developer-guide/build-an-app.md

This file was deleted.

2 changes: 0 additions & 2 deletions katacoda/scenarios/app-developer-guide/cache-image-bg.sh

This file was deleted.

Loading
Loading