-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify and expand on implications of upgrading to Platform API 0.10 #617
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
314c19f
Clarify and expand on implications of upgrading to Platform API 0.10
natalieparellano 2600a70
Merge branch 'main' into update-migration
AidanDelaney d66fec1
Merge branch 'main' into update-migration
AidanDelaney 98b8ab5
Merge branch 'main' into update-migration
AidanDelaney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,6 +38,18 @@ docker run --entrypoint from-newer-buildpack my-image user-1 user-2 | |
|
||
will result in the following command invocation: `some-command always-1 always-2 user-1 user-2`. | ||
|
||
#### Implications of upgrading | ||
|
||
For processes from newer buildpacks, upgrading the platform (without changing anything else) will change the command invocation for end-users. | ||
|
||
As an example, the following on Platform API version 0.9: | ||
|
||
``` | ||
docker run --entrypoint from-newer-buildpack my-image user-1 user-2 | ||
``` | ||
|
||
will result in the following command invocation: `some-command always-1 always-2 override-1 override-2 user-1 user-2`, where overridable arguments are treated like regular arguments, and user-provided arguments are always appended. Upgrading the platform will cause `override-1` and `override-2` to be dropped, as shown above. | ||
|
||
#### Older buildpacks | ||
|
||
Process types contributed by older buildpacks (Buildpack API 0.8 and below) do not have overridable process arguments. Looking at metadata.toml: | ||
|
@@ -51,7 +63,7 @@ args = ["always-1", "always-2"] | |
The `command` list will never have more than one element. `always-1` and `always-2` are arguments that are always provided to `some-command`. If no user-provided arguments are specified when the application image is launched, `always-1` and `always-2` will be provided only. If user-provided arguments are specified, these will be **appended** to the `args` list. Example: | ||
|
||
``` | ||
docker run --entrypoint from-newer-buildpack my-image | ||
docker run --entrypoint from-older-buildpack my-image | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixing an oops |
||
``` | ||
|
||
will result in the following command invocation: `some-command always-1 always-2`. However: | ||
|
@@ -62,6 +74,10 @@ docker run --entrypoint from-older-buildpack my-image user-1 user-2 | |
|
||
will result in the following command invocation: `some-command always-1 always-2 user-1 user-2`. | ||
|
||
#### Implications of upgrading | ||
|
||
For processes from older buildpacks, upgrading the platform will not change the command invocation. | ||
|
||
### Image extensions are supported (experimental) | ||
|
||
Platform 0.10 introduces image extensions as experimental components for customizing build and run-time base images (see [here](/docs/features/dockerfiles) for more information). Image extensions output Dockerfiles which are applied by the lifecycle using [kaniko][https://github.com/GoogleContainerTools/kaniko], a tool for building container images in Kubernetes, as a library. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Means the same thing but is more accurate