Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noted 70 character limit for adding a custom reason string for skip step attributes #2582

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

james2791
Copy link
Contributor

@james2791 james2791 commented Dec 5, 2023

A limit of 70 characters is present when passing in a reason for a skip attribute of a command step: this PR adds this as a small addendum to the command steps' optional attribute row in said table 🙂

@github-actions github-actions bot added the pipelines Pull requests that update content related to Pipelines label Dec 5, 2023
Copy link
Contributor

@mbelton-buildkite mbelton-buildkite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick, then you're all good :)

pages/pipelines/command_step.md Outdated Show resolved Hide resolved
@mbelton-buildkite mbelton-buildkite merged commit c77f1e9 into main Jan 9, 2024
2 checks passed
@mbelton-buildkite mbelton-buildkite deleted the skip-step-char-limit branch January 9, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines Pull requests that update content related to Pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants