Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace suite#show preview image on doc site #2578

Merged

Conversation

meghan-kradolfer
Copy link
Contributor

The TA docs are pretty outdated, this has started to cause some issues recently with customers wondering why their product doesn't look like the docs. https://3.basecamp.com/3453178/buckets/20365997/card_tables/cards/6803183541

I did a quick scan of bits that referenced features that have been completely removed and updated them. However I do think this needs an full check/rewrite at some point

@meghan-kradolfer meghan-kradolfer requested a review from a team November 30, 2023 21:53
@github-actions github-actions bot added the test-analytics Pull requests that update content related to Test Analytics label Nov 30, 2023
@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2578--bk-docs-preview.netlify.app


Select any individual test execution to see more trend and deep-dive information, including comparisons against previous executions of this test.

For example, in the following screenshot, you can see that the test execution duration of 5.26 seconds is 2 seconds and 233 milliseconds more than the median of the previous 25 executions. In addition, the current value for this test execution of 5.26 seconds is in the 66th percentile within the distribution over the last 25 executions.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comparison data on a test execution has been completely removed

@KatieWright26
Copy link
Contributor

Are you able to merge this now @meghan-kradolfer ?

@meghan-kradolfer
Copy link
Contributor Author

Are you able to merge this now @meghan-kradolfer ?

Just waiting for a review from @mbelton-buildkite

Copy link
Contributor

@mbelton-buildkite mbelton-buildkite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the screenshot, but looks good otherwise 😊

images/docs/test_analytics/test_suites/test-stats.png Outdated Show resolved Hide resolved
@meghan-kradolfer meghan-kradolfer force-pushed the pie-2176-replace-suiteshow-preview-image-on-doc-site branch from d9ccd03 to 429db7b Compare December 13, 2023 20:19
@meghan-kradolfer meghan-kradolfer merged commit 0dab31e into main Dec 13, 2023
3 checks passed
@meghan-kradolfer meghan-kradolfer deleted the pie-2176-replace-suiteshow-preview-image-on-doc-site branch December 13, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-analytics Pull requests that update content related to Test Analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants