Fix rendering ERB partial #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a single ERB partial that renders a relative timestamps as example input. This change updates the `render_markdown` partial to support rendering ERB html templates.
|
Preview URL: https://2575--bk-docs-preview.netlify.app |
mbelton-buildkite
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gchan recently noticed that we've got a some ERB tags rendering on https://buildkite.com/docs/apis/rest-api/builds.
I believe this broke quite a while back. Most likely when we renamed all the
md.erbfiles to.md.Since there was no markdown in this partial, this PR updates the file extension and
md->html.erbin order for the ERB processor to kick in, and fixes the issue.