Merge pull request #1479 from buildkite/keithduncan/fix-off-by-one

Fix redactor table size
buildkite · Aug 6, 2021 · e6c4a51 · e6c4a51
2 parents 8a5492d + 6f49c03
commit e6c4a51
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/bootstrap/redactor.go b/bootstrap/redactor.go
@@ -16,7 +16,7 @@ type Redactor struct {
 	maxlen int
 
 	// Table of Boyer-Moore skip distances, and values to redact matching this end byte
-	table [255]struct {
+	table [256]struct {
 		skip    int
 		needles [][]byte
 	}

diff --git a/bootstrap/redactor_test.go b/bootstrap/redactor_test.go
@@ -112,3 +112,11 @@ func TestRedactorSubsetSecrets(t *testing.T) {
 		t.Errorf("Redaction failed: %s", buf.String())
 	}
 }
+
+func TestRedactorLatin1(t *testing.T) {
+	var buf bytes.Buffer
+	redactor := NewRedactor(&buf, "[REDACTED]", []string{"ÿ"})
+
+	redactor.Write([]byte("foo"))
+	redactor.Flush()
+}