Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace utcnow calls #394

Merged
merged 4 commits into from
Jan 13, 2025
Merged

replace utcnow calls #394

merged 4 commits into from
Jan 13, 2025

Conversation

clr182
Copy link

@clr182 clr182 commented Nov 5, 2024

Goal

DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC)

Changeset

Removed datetime.utcnow() call, as I believe it was just used to trigger the exception in the try/catch. Instead I've added sys.version_info checking to determine which method to use in the date formatting.

@clr182 clr182 requested a review from tomlongridge November 11, 2024 16:37
@tomlongridge tomlongridge changed the base branch from master to next December 13, 2024 10:15
@tomlongridge tomlongridge requested a review from Cawllec December 13, 2024 10:16
@clr182 clr182 merged commit 55e52dd into next Jan 13, 2025
43 checks passed
@clr182 clr182 deleted the utcnow-deprecated branch January 13, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants