Stop trimming everything before "main.go" on main packages #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DariaKunoichi
force-pushed
the
daria-PLAT-11584-alt
branch
from
98b38d3 to
0da6720
Compare
Merged
DariaKunoichi
added a commit
that referenced
this pull request
Mar 5, 2024
## 2.3.0 (2024-03-05) ### Bug fixes * Start showing inlined functions in stack trace [#208](#208) * Handle complex structs in metadata [#215](#215) [Chris Duncan](https://github.com/veqryn) * Stop trimming everything before "main.go" on main packages [#217](#217) [Chris Duncan](https://github.com/veqryn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
In case of different main files it's impossible to differentiate which main file the error came from.
Design
It's less invasive than correcting the order of trimming paths. (#211)
First trimming is performed for every package and it trims everything until the package name.
It's mostly for external packages or golang internal pkg.
Because
mainis a special package (pkg name is just "main" without module) we omit it in the first trimming.Then if it's added to ProjectPackages and SourceRoot is properly configured the path will be trimmed properly.
So for input path: "/user/name/work/cmd/main.go"
current solution will provide: "main.go"
and this PR's solution will provide either "/user/name/work/cmd/main.go" or "cmd/main.go" depending of whether SourceRoot is configured.
Changeset
Skipped trimming path for "main" package.
Testing
Adjusted maze tests - for testcases that check
main.goline numbers we setupSourceRootso that main's path is trimmed correctly.