go: more regression fixes for optional values (#575)

Signed-off-by: Matt Klein <[email protected]>
bufbuild · Mar 1, 2022 · 0f87cc3 · 0f87cc3
1 parent 7518d9e
commit 0f87cc3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/templates/goshared/register.go b/templates/goshared/register.go
@@ -226,7 +226,8 @@ func (fns goSharedFuncs) inType(f pgs.Field, x interface{}) string {
 		if f.Type().IsRepeated() {
 			return strings.TrimLeft(fns.Type(f).String(), "[]")
 		} else {
-			return fns.Type(f).String()
+			// Use Value() to strip any potential pointer type.
+			return fns.Type(f).Value().String()
 		}
 	default:
 		// Use Value() to strip any potential pointer type.

diff --git a/tests/harness/cases/enums.proto b/tests/harness/cases/enums.proto
@@ -52,4 +52,8 @@ message EnumInsideOneOf {
     oneof foo {
         TestEnum val = 1 [(validate.rules).enum.defined_only = true];
     }
+
+    oneof bar {
+        TestEnum val2 = 2 [(validate.rules).enum = {defined_only : true not_in : 0}];
+    }
 }