Use groups_$action_member() function to manage memberships
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests will stop fail once buddypress/buddypress#293 is committed! |
This makes sure cache is cleared, group activities are removed etc..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on https://buddypress.trac.wordpress.org/ticket/9158 I realized using
BP_Groups_Member->$action()methods was not a great idea. We really need to usegroups_$action_member()functions instead.In buddypress/buddypress#293 I'm updating these functions so that it's possible to use them from the REST API (the
bp_is_item_admin()checks were restricting their use to the Web).This makes sure cache is cleared, group activities are removed when needed etc...
See: https://github.com/buddypress/buddypress/blob/edd1d2e33a2a4d3ace8216e06ba846a36f452b88/src/bp-groups/bp-groups-cache.php#L391|L394