Decode List(Text) encoded by other tools #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to actually check this works... |
bucko909
force-pushed
the
list-list
branch
2 times, most recently
from
71ba16b to
62c1429
Compare
|
(Fixed one sanity check and added another.) |
kvelicka
reviewed
Apr 9, 2021
I will make it not require a tag, this will capture all schema changes to avoid pollution
Without this, a `List(Text)` (which is `List(List(Int8))`) which is not
encodeded as `List(struct { x @0 :Text; })`, will decode the first text
pointer as a tag and get very wrong answers. The patch:
* Makes sure we give a sensible error for unsupported types.
* Provides better checking that data is correctly formatted.
* Also adds support for decoding `List(Text)` correctly, as well as
decoding `List(struct {})` which was upgraded from `List(Int64)` or
`List(AnyPointer)` (or compatible types).
We still don't support double lists.
This relates to Issue #3 (which relies on the upgrade decoding for its
`List(Text)` encoding to be valid).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, a
List(Text)(which isList(List(Int8))) which is notencodeded as
List(struct { x @0 :Text; }), will decode the first textpointer as a tag and get very wrong answers. The patch:
List(Text)correctly, as well asdecoding
List(struct {})which was upgraded fromList(Int64)orList(AnyPointer)(or compatible types).We still don't support double lists.
This relates to Issue #3 (which relies on the upgrade decoding for its
List(Text)encoding to be valid).