Add merge reducer option #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, failed to go through all open PRs and see that this is a duplicate of #100. It's been open for a year and is stale now so I won't close this just yet. |
|
@BBlackwo I named it |
BBlackwo
approved these changes
Mar 11, 2020
|
Thanks for this @rowandh! I will try and get this bundled into a |
|
Also, thank you for the very thorough description. Once this is released I will close those issues that you mentioned that this solves. |
|
Version 9 has been released, including this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to define a custom reducer for merging the rehydrated storage state with the store. If no merge reducer is specified, defaults to the current deepmerge on
INITandUPDATEstrategy. This shouldn't change any existing behaviour.Seems like this idea was already proposed in #65 before deepmerge was selected as the default strategy, but it's become pretty obvious that there's no one-size-fits-all solution here.
Resolves issues like #114, #110, #80 and #128 by allowing custom merge reducers to be defined for these use-cases. Resolves issues like #120 by allowing rehydrated state to be updated on any desired action.
See test for an example of a combined merge strategy using both deepmerge and object.assign.