Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify forkjoin error behavior #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions operators/combination/forkjoin.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ similar to how you might use
Be aware that if any of the inner observables supplied to `forkJoin` error you
will lose the value of any other observables that would or have already
completed if you do not [`catch`](../error_handling/catch.md) the
[error correctly on the inner observable](#example-4-getting-successful-results-when-one-innner-observable-errors).
If you are only concerned with all inner observables completing successfully you
can [catch the error on the outside](#example-3-handling-errors-on-outside).
[error correctly on the inner observable](#example-5-getting-successful-results-when-one-innner-observable-errors).
Without catching on the inner observable an error will cause all observables to
immediately be unsubscribed. If this is not an issue you
can [catch the error on the outside](#example-4-handling-errors-on-outside).

It's also worth noting that if you have an observable that emits more than one
item, and you are concerned with the previous emissions `forkJoin` is not the
Expand Down