GLCanvasScissor : fix width calculation

brunotl · May 12, 2024 · f683abd · f683abd
1 parent 492e315
commit f683abd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/Common/Source/xcs/Screen/Custom/Point.hpp b/Common/Source/xcs/Screen/Custom/Point.hpp
@@ -139,8 +139,16 @@ struct PixelRect {
     return { left, top };
   }
 
+  constexpr PixelScalar GetWidth() const {
+    return right - left;
+  }
+
+  constexpr PixelScalar GetHeight() const {
+    return bottom - top;
+  }
+
   constexpr PixelSize GetSize() const {
-    return { right - left, bottom - top };
+    return { GetWidth(), GetHeight() };
   }
 
   constexpr RasterPoint GetCenter() const {

diff --git a/Common/Source/xcs/Screen/OpenGL/Scissor.hpp b/Common/Source/xcs/Screen/OpenGL/Scissor.hpp
@@ -50,7 +50,7 @@ class GLCanvasScissor : public GLEnable<GL_SCISSOR_TEST> {
 private:
   void Scissor(PixelRect rc) {
     OpenGL::ToViewport(rc);
-    ::glScissor(rc.left, rc.top, rc.right - rc.left, rc.bottom - rc.top);
+    ::glScissor(rc.left, rc.top, rc.GetWidth(), rc.GetHeight());
 #if HAVE_GLES
     OpenGL::scissor_test = true;
 #endif
@@ -69,7 +69,7 @@ class GLCanvasScissor : public GLScissor {
   explicit GLCanvasScissor(PixelRect rc)
     :GLScissor(OpenGL::translate.x + rc.left,
                OpenGL::viewport_size.y - OpenGL::translate.y - rc.bottom,
-               rc.right - rc.top, rc.bottom - rc.top) {}
+               rc.GetWidth(), rc.GetHeight()) {}
 };
 
 #endif