Improve camera module.

- Add value type for KeyCameraIsRecording. - Fix camera connection handling.
brunoga · May 21, 2024 · 4f54e6b · 4f54e6b
1 parent 7de3cb8
commit 4f54e6b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/module/camera/camera.go b/module/camera/camera.go
@@ -60,7 +60,7 @@ func New(ub unitybridge.UnityBridge, l *logger.Logger,
 				return
 			}
 
-			if ok, connected := r.Value().(bool); ok && connected {
+			if connected, ok := r.Value().(*bool); ok && *connected {
 				l.Debug("** Camera connected **")
 				// Ask for video texture information.
 				if err := c.UB().SendEvent(event.NewFromType(
@@ -70,7 +70,7 @@ func New(ub unitybridge.UnityBridge, l *logger.Logger,
 				}
 			} else if !ok {
 				l.Debug("** Camera connection result value not a bool **")
-			} else if !connected {
+			} else if !*connected {
 				l.Debug("** Camera not connected **")
 			}
 		}, cm)

diff --git a/unitybridge/unity/key/key.go b/unitybridge/unity/key/key.go
@@ -43,7 +43,7 @@ var (
 	KeyCameraPhotoSize                             = newKey("KeyCameraPhotoSize", 16777221, AccessTypeRead|AccessTypeWrite, nil)
 	KeyCameraStartRecordVideo                      = newKey("KeyCameraStartRecordVideo", 16777222, AccessTypeAction, nil)
 	KeyCameraStopRecordVideo                       = newKey("KeyCameraStopRecordVideo", 16777223, AccessTypeAction, nil)
-	KeyCameraIsRecording                           = newKey("KeyCameraIsRecording", 16777224, AccessTypeRead, nil)
+	KeyCameraIsRecording                           = newKey("KeyCameraIsRecording", 16777224, AccessTypeRead, &value.Bool{})
 	KeyCameraCurrentRecordingTimeInSeconds         = newKey("KeyCameraCurrentRecordingTimeInSeconds", 16777225, AccessTypeRead, nil)
 	KeyCameraVideoFormat                           = newKey("KeyCameraVideoFormat", 16777226, AccessTypeRead|AccessTypeWrite, nil)
 	KeyCameraMode                                  = newKey("KeyCameraMode", 16777227, AccessTypeRead|AccessTypeWrite, nil)