Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes + last game bugfix #6

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Various fixes + last game bugfix #6

wants to merge 13 commits into from

Conversation

Tempystral
Copy link

@Tempystral Tempystral commented Oct 24, 2020 •
edited
Loading

I started poking around to make my own additions, and performed some code cleanup to make the script easier to work with.
Highlights:

  • Seed is now loaded from getSettings() function correctly
  • Redundant or unnecessary variables removed
  • Made global variables local where possible
  • Moved some boilerplate code to functions
  • Added comments
  • Removed the "DeleteMe" files, as they seemed to break things more than help. If you want me to change this back, let me know.

@Tempystral
Load database in function, change while->for
ab919c6
@Tempystral
Change var i to local, remove global
e90bb7b
@Tempystral
Move database update into function for cleanliness
e27ca82
@Tempystral
ranNumber -> randNumber
db2d44d
@Tempystral
Made function names consistent
a01a006
@Tempystral
Cleanup of openCurrentTime()
682be88 
Moevd globals to locals where required, added comments
@Tempystral
setBuffer() function
4ff89af 
Made the countdown and buffer defaults unambiguous, cleaned up their init checks. Also put buffer init into a function.
@Tempystral
Removed redundant code
9ec54e9 
As far as I can tell it doesn't do anything.
@Tempystral
Update saveTime function
38beb57 
Changed globals to locals where possible, made default timeLimit clearer
@Tempystral
Store seed in getSettings
725e456 
Made seed global, allowing settingsValue to become local. Made other variables local as well. Seed is now retrieved in the getSettings function.
@Tempystral Tempystral changed the title Code cleanup for workability Make variables local where possible, load seed from getSettings() Oct 25, 2020
@Tempystral
Update nextGame() function
1d8a758 
Fixed bugs in nextGame() function.
- Removing all but one game now works correctly in all conditions
- States are no longer saved and loaded when there is one game left and it has not changed
@Tempystral Tempystral changed the title Make variables local where possible, load seed from getSettings() Various fixes + last game bugfix Oct 25, 2020
@Tempystral
Copy link
Author

This PR now addresses issues #7 and #8. In addition to code cleanup, this fork ensures that BizHawk always loads the final rom correctly, and does not interrupt gameplay when it is the final rom in the list.

@Tempystral
Don't update currentChangeCount for same game
bf0aa9d 
When one game is left, don't update the change count between countdowns. This will still write a "1" if the game had not been played before.
@Tempystral
Merge remote-tracking branch 'upstream/main' into main
16a2242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tempystral