Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT RFC: remove extra android build support #403

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

DRAFT RFC: remove extra android build support #403

wants to merge 9 commits into from

Conversation

brodycj
Copy link
Owner

@brodycj brodycj commented Feb 10, 2021 •
edited
Loading

updated:

  • remove support for generating Maven package for Android (there will be an option to enable this)
  • remove Android root build support (build outside of generated example test app) (there will be an option to enable this)
  • remove default Android SDK versions (not needed if the generated module is part of a larger RN app) - this change will not likely be merged in the near future

✅ I have tested that removing these items does not cause issues with the example app.

This was referenced Feb 10, 2021
Closed
Draft
@brodycj brodycj marked this pull request as draft February 12, 2021 03:38
@brodycj brodycj mentioned this pull request Feb 12, 2021
Open
13 tasks
@brodycj brodycj mentioned this pull request Feb 24, 2021
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brodycj