Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update terra introspection to support GCP Batch backend #575

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tomkinsc
Copy link
Member

This updates the check_terra_env WDL task so environment introspection supports execution under GCP Batch, which is the announced successor to the deprecated Google Life Sciences API (aka PAPIv2).

With the changes in this PR, the workspace UUID can now be determined when Terra tasks are running via GCP Batch, and booleans are now exposed to reflect whether GCP jobs are running via Batch or PAPIv2.

Additionally, the workspace_id output has been renamed to workspace_uuid to reflect the fact that workspace_id is now a reserved keyword unavailable on Terra for WDL outputs.

… which we scrape env info; check workspace ID is valid UUID

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…the GCP Life Sciences API)
@tomkinsc tomkinsc requested a review from dpark01 January 14, 2025 02:42
Copy link
Member

@dpark01 dpark01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks for doing this!

Out of total curiosity (ie, don't wait to merge this PR), what happens if you dsub --provider google-batch ..... miniwdl run --task check_terra_env ... (or --provider google-cls-v2)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants