docker build fix and filter_taxids_to_focal_hits fix #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpark01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critical fix to docker build: specify viral-core's requirements-conda.txt alongside viral-classify's for mamba solve so that installing new packages doesn't degrade/break viral-core packages.
Also update versions and loosen version pins for various conda packages.
Bugfix to
metagenomics.filter_taxids_to_focal_hitshandling of taxids (behavior was wrong for including children of observed nodes).Fix to unit testing of blast depletion: newer versions of blast have more index files than before.