Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-69: scala, sbt, plugins updates #350

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Nov 12, 2024

Jira: https://broadworkbench.atlassian.net/browse/CORE-69

Updates Scala, sbt, sbt plugins, and the scala-sbt docker image. Makes some very minor syntax tweaks to address syntax that was previously allowed but in the new version of Scala is now illegal. Updates scalatest and mockito-scala-scalatest.

This consolidates Scala Steward PRs #343, #281, #322, #323, #327, #288, #289.


  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Submitter: If you're adding new libraries, sign us up to security updates for them

@davidangb davidangb requested a review from a team as a code owner November 12, 2024 19:30
@davidangb davidangb requested review from dvoet and marctalbott and removed request for a team November 12, 2024 19:30
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.65%. Comparing base (b9f7620) to head (ffbb8fa).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #350      +/-   ##
===========================================
- Coverage    59.87%   59.65%   -0.22%     
===========================================
  Files           18       18              
  Lines          638      637       -1     
  Branches        65       72       +7     
===========================================
- Hits           382      380       -2     
- Misses         256      257       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants