Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-127: enforce scalafmt in github actions #338

Closed
wants to merge 1 commit into from

Conversation

davidangb
Copy link
Contributor

Followup to #337

That other PR performed a mass reformat of code to meet scalafmt standards.

This PR adds:

  • a format check in github actions for PRs
  • introduction of .git-blame-ignore-revs, so the mass reformat doesn't show up in git blames

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.27%. Comparing base (bcd8b62) to head (19b212a).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #338   +/-   ##
========================================
  Coverage    59.27%   59.27%           
========================================
  Files           18       18           
  Lines          636      636           
  Branches        68       68           
========================================
  Hits           377      377           
  Misses         259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidangb davidangb marked this pull request as draft October 25, 2024 19:03
@davidangb
Copy link
Contributor Author

obsoleted by #337

@davidangb davidangb closed this Oct 25, 2024
@davidangb davidangb deleted the da_CORE-127_scalafmtEnforcement branch October 25, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant