Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID-985 Add sentry-logback dependency. #247

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

Ghost-in-a-Jar
Copy link
Contributor

@Ghost-in-a-Jar Ghost-in-a-Jar commented Dec 21, 2023

Jira: https://broadworkbench.atlassian.net/browse/ID-985

I noticed this in the logs: Failed to instantiate type com.getsentry.raven.logback.SentryAppender

In order to work with logback, sentry needs this dependency. It was also being referenced improperly in the logback config.


  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Submitter: If you're adding new libraries, sign us up to security updates for them

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (dac34f1) 61.10% compared to head (ece1f99) 60.06%.
Report is 2 commits behind head on develop.

Files Patch % Lines
src/main/scala/thurloe/dataaccess/HttpSamDAO.scala 0.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #247      +/-   ##
===========================================
- Coverage    61.10%   60.06%   -1.04%     
===========================================
  Files           14       14              
  Lines          563      581      +18     
  Branches        47       50       +3     
===========================================
+ Hits           344      349       +5     
- Misses         219      232      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ghost-in-a-Jar Ghost-in-a-Jar merged commit 30128f7 into develop Jan 2, 2024
3 of 5 checks passed
@Ghost-in-a-Jar Ghost-in-a-Jar deleted the add-sentry-logback branch January 2, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants