Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID-946 Upgrade logback-classic to fix vulnerability. #244

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

Ghost-in-a-Jar
Copy link
Contributor

@Ghost-in-a-Jar Ghost-in-a-Jar commented Dec 19, 2023

Jira: https://broadworkbench.atlassian.net/browse/ID-946

The following version in use was found to contain a vulnerability: 1.2.10

Upgradingto a non-vulnerable version of this library will fix this finding. The fixed version of this library is: 1.3.12

This pr also updates logback core since it is a dependency of logback classic.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (dac34f1) 61.10% compared to head (96d9e4d) 60.06%.
Report is 1 commits behind head on develop.

Files Patch % Lines
src/main/scala/thurloe/dataaccess/HttpSamDAO.scala 0.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #244      +/-   ##
===========================================
- Coverage    61.10%   60.06%   -1.04%     
===========================================
  Files           14       14              
  Lines          563      581      +18     
  Branches        47       50       +3     
===========================================
+ Hits           344      349       +5     
- Misses         219      232      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI -- the description references a different logback-classic version than the one in the PR, but the committed version looks good :)

@Ghost-in-a-Jar Ghost-in-a-Jar merged commit fffcd37 into develop Dec 19, 2023
3 of 5 checks passed
@Ghost-in-a-Jar Ghost-in-a-Jar deleted the ID-946-upgrade-logback-classic-vuln-fix branch December 19, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants