-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added option to ignore illegal headers #973
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh jeez maybe I didn't actually test this in a bee
Manual Testing done on configs:
set: x-forwarded-host is supressed but user-agent warnings are not
both x-forwarded-host and user-agent errors are suppressed |
@@ -3,6 +3,9 @@ akka { | |||
server { | |||
idle-timeout = 180 s | |||
request-timeout = 60 s | |||
parsing { | |||
ignore-illegal-header-for = ${?IGNORE_ILLEGAL_HEADERS} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind adding a comment explaining what this is and why it might be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gladly! hows that?
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
jenkins retest |
Ticket: https://broadworkbench.atlassian.net/browse/DDO-2622
What: Adds a new config option to sam's conf for ignoring bad header. This feature was removed in the fc-dev removal, original thread: https://broadinstitute.slack.com/archives/CADM7MZ35/p1665685716707079?thread_ts=1665522324.115159&cid=CADM7MZ35
Why: Becuase otherwise sam (only in BEEs, or any terra using an NGINX ingress) will continously throw
x-forwarded-host
herrorsHow: adds a config to option to ignore those warnings
PR checklist