Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-232: user supportSummary should use resource_type_admin #1621

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Jan 9, 2025

Ticket: https://broadworkbench.atlassian.net/browse/CORE-232

What:

  • change the GET /api/admin/v1/user/email/{email}/supportSummary API to require the admin_read_summary_information action on the user resource_type_admin instead of requiring workbench admin
  • remove the groupMembershipCounts.unsynchronized count from the support summary. This number was incorrect and unhelpful.

See #1617 for the original implementation.


PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

Copy link

sonarqubecloud bot commented Jan 9, 2025

@davidangb davidangb marked this pull request as ready for review January 9, 2025 21:09
@davidangb davidangb requested a review from a team as a code owner January 9, 2025 21:09
@davidangb davidangb requested review from kevinpalis and dvoet January 9, 2025 21:09
@davidangb davidangb merged commit efbf001 into develop Jan 9, 2025
26 checks passed
@davidangb davidangb deleted the da_CORE-232_supportPermissions branch January 9, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants