Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-40] add read_spend_report action to workspace owners #1600

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

calypsomatic
Copy link
Contributor

@calypsomatic calypsomatic commented Nov 22, 2024

Ticket: https://broadworkbench.atlassian.net/browse/CORE-40

What:

Adds a read_spend_report action on workspaces, and grants it to workspace owners.

Why:

<For your reviewers' sake, please describe in ~1 paragraph what the value of this PR is to our users or to ourselves.>

How:

<For your reviewers' sake, please describe in ~1 paragraph how this PR accomplishes its goal.>

<If the PR is big, please indicate where a reviewer should start reading it (i.e. which file or function).>


PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

Copy link
Contributor

@marctalbott marctalbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all you'll need in Sam. The other actions that are present in the code are actions that Sam requires for its own internal operations (e.g. read_policies is required to read the Sam policies on a resource). Adding it to Sam's config like this is sufficient for an action like this that governs an operation in an upstream service.

@calypsomatic calypsomatic changed the title add read_spend_report action to workspace owners [CORE-40] add read_spend_report action to workspace owners Nov 22, 2024
@calypsomatic calypsomatic marked this pull request as ready for review November 22, 2024 16:14
@calypsomatic calypsomatic requested a review from a team as a code owner November 22, 2024 16:14
@calypsomatic calypsomatic merged commit cbdf088 into develop Nov 22, 2024
24 checks passed
@calypsomatic calypsomatic deleted the core-40-read-spend-workspace branch November 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants