Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-131 adminGetUsersByIDs searches more kinds of ids #1576

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

dvoet
Copy link
Collaborator

@dvoet dvoet commented Oct 31, 2024

Ticket: https://broadworkbench.atlassian.net/browse/CORE-131

What:

Make the adminGetUsersByIDs api accept azure b2c and google subject ids in addition to already supported sam ids.

Why:

Orch needs to resolve email addresses for ids returned from Thurloe and at this point there is no telling which id Thurloe will return. Orch currently asks Thurloe for these email addresses but after a change in August, NIH user ids and user emails are stored under different ids. This api will be used to resolve the correct email regardless of which id Thurloe returns.


PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

@dvoet dvoet requested review from a team, marctalbott and kevinmarete and removed request for a team October 31, 2024 15:56
Copy link

@dvoet dvoet merged commit 0f47b00 into develop Oct 31, 2024
25 checks passed
@dvoet dvoet deleted the more_ids branch October 31, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants