CORE-101 don't attempt to create shell google project if key exists #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoet
commented
Oct 18, 2024
| @@ -46,6 +45,10 @@ import scala.jdk.CollectionConverters._ | |||
| object GoogleExtensions { | |||
| val resourceId = ResourceId("google") | |||
| val getPetPrivateKeyAction = ResourceAction("get_pet_private_key") | |||
|
|
|||
| def getShellGoogleProjectName(user: SamUser, googleServicesConfig: GoogleServicesConfig) = | |||
There was a problem hiding this comment.
moved to be in a more accessible spot for tests
dvoet
commented
Oct 18, 2024
| @@ -485,9 +488,6 @@ class GoogleExtensions( | |||
| } | |||
| } yield key | |||
|
|
|||
| def getArbitraryPetServiceAccountKey(user: SamUser, samRequestContext: SamRequestContext): IO[String] = | |||
dvoet
changed the title
dvoet
requested review from
a team,
calypsomatic and
davidangb
and removed request for
a team
calypsomatic
approved these changes
Oct 18, 2024
davidangb
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
👍, with a question: this is still going to be vulnerable to multiple requests hitting getArbitraryPetServiceAccountKey in short order - if the user has multiple tabs open, or even if a script or the UI shoots off multiple requests that each involve a pet.
Certainly this PR is better than before, so it's worth merging; is it worth protecting against multiple requests?
|
davidangb
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/CORE-101
<Don't forget to include the ticket number in the PR title!>
What:
<For your reviewers' sake, please describe in a sentence or two what this PR is accomplishing (usually from the users' perspective, but not necessarily).>
Why:
<For your reviewers' sake, please describe in ~1 paragraph what the value of this PR is to our users or to ourselves.>
How:
<For your reviewers' sake, please describe in ~1 paragraph how this PR accomplishes its goal.>
<If the PR is big, please indicate where a reviewer should start reading it (i.e. which file or function).>
PR checklist